This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH: Add two ObjC++ callback functions to cp/decl.c
Ziemowit Laski wrote:
I think you need to get these kinds of patches reviewed and
approved. They're not "obvious" just because they "don't affect C++
control flow."
I guess what I meant is that they're obvious from _your_/C++
perspective, since C++ execution is not altered by it. No, I suppose
they're not obvious from the ObjC++ perspective, but I take full
responsibility for it as the ObjC++ maintainer. :-)
These patches are occurring in the C++ front end. Therefore, a C++
front-end maintainer should approve them. Just because they are only
used in Objective-C++ does not mean that they have no impact on the C++
front end. For example, a change to these data structures now requires
changing your new code as well. Therefore, you should be coordinating
with the C++ maintainers to make sure that what you're doing is
consonant with any other plans in the works.
--
Mark Mitchell
CodeSourcery, LLC
(916) 791-8304
mark@codesourcery.com