This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: RFA: Fix FR-V maddacc/msubacc patterns
- From: Aldy Hernandez <aldyh at redhat dot com>
- To: Richard Sandiford <rsandifo at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org, aoliva at redhat dot com
- Date: Fri, 10 Sep 2004 10:04:55 -0400
- Subject: Re: RFA: Fix FR-V maddacc/msubacc patterns
- References: <87fz5r36e3.fsf@redhat.com>
On Thu, Sep 09, 2004 at 02:43:00PM +0100, Richard Sandiford wrote:
> This patch fixes the FR-V maddacc, msubacc, mdaddacc and mdsubacc patterns.
> It was inadvertently missing from yesterday's jumbo FR-V submission.
>
> The problem was that we were trying to use the same define_insns for
> maddacc, msubacc and masacc, with an integer operand to distinguish
> them. This is wrong because maddacc and msubacc just set a single
> accumulator whereas masacc sets two (it does both an addition and
> a subtraction). The same problem applied to mdaddacc and mdsubacc.
>
> The patch fixes the operands of the affected patterns and moves masacc
> and mdasacc into separate define_insns. The testcase is included in the
> testsuite patch that I'm about to submit.
>
> Tested on frv-elf. OK to install?
This is OK.