This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] PR middle-end/17055: Casting integer zero to a vector

From: Richard Henderson <rth at redhat dot com>
To: Zack Weinberg <zack at codesourcery dot com>
Cc: Roger Sayle <roger at eyesopen dot com>, gcc-patches at gcc dot gnu dot org, Jim Wilson <wilson at specifixinc dot com>
Date: Wed, 8 Sep 2004 12:18:38 -0700
Subject: Re: [PATCH] PR middle-end/17055: Casting integer zero to a vector
References: <Pine.LNX.4.44.0409081150310.19509-100000@www.eyesopen.com> <873c1spopb.fsf@codesourcery.com>

On Wed, Sep 08, 2004 at 12:04:16PM -0700, Zack Weinberg wrote:
> > +   elem = fold_convert_const (NOP_EXPR, TREE_TYPE (type), integer_zero_node);
> 
> I'd just like to point out that this is better written
> 
>     elem = build_int_cst (TREE_TYPE (type), 0);
> 
> these days.

fold_convert_const also handles real types.

Although you could probably do

	subtype = TREE_TYPE (type);
	if (TREE_CODE (subtype) == REAL_TYPE)
	  elem = build_real (subtype, dconst0);
	else
	  elem = build_int_cst (subtype, 0);


r~

References:
- [PATCH] PR middle-end/17055: Casting integer zero to a vector
  - From: Roger Sayle
- Re: [PATCH] PR middle-end/17055: Casting integer zero to a vector
  - From: Zack Weinberg

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]