This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [assert] g*.c files

From: Mark Mitchell <mark at codesourcery dot com>
To: Nathan Sidwell <nathan at codesourcery dot com>
Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
Date: Wed, 08 Sep 2004 08:58:41 -0700
Subject: Re: [assert] g*.c files
Organization: CodeSourcery, LLC
References: <413F077F.3050300@codesourcery.com>

Nathan Sidwell wrote:

Hi,
this patch converts the non-generator g*.c files.  There are a couple of
issues with this patch that I'd like advice on, before committing.
1) gcc.c contains a number of 'if (expr) abort ()', where expr is testing something about a spec string. Should these really become asserts? or should they become fatal_error?

Fatal errors; since we provide ways for users to provide specs directly, we should issue sensible error messages if we can.

2) ggc-{page,zone}.c & gimplify.c contain a number of 'if (simpleexpr) abort ()' protected by ENABLE_CHECKING. My inclination is to remove the ENABLE_CHECKING guard, and turn these into regular asserts.

I agree.

--
Mark Mitchell
CodeSourcery, LLC
(916) 791-8304
mark@codesourcery.com

References:
- [assert] g*.c files
  - From: Nathan Sidwell

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]