This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Prettify assembly output on SPARC (part #2)
- From: Hans-Peter Nilsson <hp at bitrange dot com>
- To: Eric Botcazou <ebotcazou at libertysurf dot fr>
- Cc: gcc-patches at gcc dot gnu dot org, dave dot anglin at nrc dot ca, joern dot rennecke at superh dot com
- Date: Sun, 5 Sep 2004 11:06:40 -0400 (EDT)
- Subject: Re: [PATCH] Prettify assembly output on SPARC (part #2)
- References: <200407091202.59122.ebotcazou@libertysurf.fr>
On Fri, 9 Jul 2004, Eric Botcazou wrote:
> The patch tweaks final.c to let it output insns in a delay slot with a
> 1-space indentation over the normal ones. This makes it easier for humans
> to parse the assembly output:
But breaks targets using #NO_APP. Consider adding a newline
afterwards instead, or make this change target-tweakable. (A
space isn't "prettyfying".)
Anyway, you can definitely do this in your target instead (see
CRIS) and I think that's much preferrable. What's "pretty" is
in the eye of the target maintainer.
Now that the patch has been approved, you broke cris-*.
Please revert.
I wouldn't have thought the patch would be accepted without the
targetification, so I didn't voice concern... :-(
brgds, H-P