This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Save GGC garbage produced by gimplifier

> Jason Merrill wrote:
> 
> >On Fri, 03 Sep 2004 13:44:53 -0400, Jason Merrill <jason@redhat.com> wrote:
> >
> > 
> >
> >>>+   local_names = NULL;
> >>>     
> >>>
> >>local_names is a tree varray
> >>   
> >>
> >
> >...so it will be freed by garbage collection.  Never mind.
> > 
> >
> I agree with Jason's comments; this looks OK.

Thanks.  I will commit it then and test additional patch removing those
two variables too.  I must've missed them.
> 
> As for your other question (can we avoid putting these things in the 
> tree structure in the first place) the answer is probably yes -- but I'm 
> not sure it's a big win.

About 26MB out of 260MB of memory usage on Gerald's testcase (-O0) we
burn in DECL_P nodes.  I unforutnately don't have the info about about
FUNCION_DECL specifically handy, but it looks like atually saving some
pointers here won't hurt at all.

Honza
> 
> -- 
> Mark Mitchell
> CodeSourcery, LLC
> (916) 791-8304
> mark@codesourcery.com
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]