This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [gfortran] PR 15327: Fix merge intrinsic for strings


Paul Brook wrote:
> Ok, except you might want to consider:
> 
> 
>>!       type = TREE_TYPE (tsource);
>>!       se->expr = fold (build3 (COND_EXPR, type, mask, tsource, fsource));
> 
> 
> This is the same in both cases, so could be moved outside the if.

I didn't feel strongly either way, I moved those two lines out the if, but
kept the line which sets mask inside the if: even though it's redundant I felt
it would be preferable to keep the argument lists together.

- Tobi


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]