This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH][3.4] for PR16408
- From: Jeffrey A Law <law at redhat dot com>
- To: Zdenek Dvorak <rakdver at atrey dot karlin dot mff dot cuni dot cz>
- Cc: gcc-patches at gcc dot gnu dot org, mark at codesourcery dot com
- Date: Tue, 31 Aug 2004 23:58:29 -0600
- Subject: Re: [PATCH][3.4] for PR16408
- Organization: Red Hat, Inc
- References: <20040825181658.GA23620@atrey.karlin.mff.cuni.cz>
- Reply-to: law at redhat dot com
On Wed, 2004-08-25 at 12:16, Zdenek Dvorak wrote:
> Hello,
>
> replace_store_insn removes an insn, but leaves references to it
> in libcall/retval notes. This causes an attempt to remove the
> insn second time in dce and consequently the ICE.
>
> The same problem is latently present in mainline.
>
> Bootstrapped and regtested on i686.
>
> Zdenek
>
> PR rtl-optimization/16408
> * gcse.c (replace_store_insn): Fix LIBCALL/RETVAL notes.
This seems pretty reasonable to me. Consider it approved for
mainline. Mark has the final say for gcc-3.4 (of course).
Jeff