This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] PR14841 and PR15838

From: "Giovanni Bajo" <rasky at develer dot com>
To: "Diego Novillo" <dnovillo at redhat dot com>
Cc: <gcc-patches at gcc dot gnu dot org>
Date: Tue, 31 Aug 2004 18:30:44 +0200
Subject: Re: [PATCH] PR14841 and PR15838
References: <200408311810.39786.stevenb@suse.de> <1093969203.3306.27.camel@localhost.localdomain>

Diego Novillo wrote:

> On Tue, 2004-08-31 at 12:10, Steven Bosscher wrote:
> 
>> !       else if (((TREE_CODE (rhs) == ARRAY_REF
>> !          && TREE_CODE (var = TREE_OPERAND (rhs, 0)) == VAR_DECL
>> ! && TREE_CODE (TREE_TYPE (var)) == ARRAY_TYPE)
>> !         || (TREE_CODE (rhs) == COMPONENT_REF
>> !     && TREE_CODE (var = TREE_OPERAND (rhs, 0)) == VAR_DECL
>> !     && TREE_CODE (TREE_TYPE (var)) == RECORD_TYPE
>> !     && TREE_CODE (TREE_OPERAND (rhs, 1)) == FIELD_DECL))
>> !        && TREE_READONLY (var)
>> !        && DECL_INITIAL (var)
>> !        && TREE_CODE (DECL_INITIAL (var)) == CONSTRUCTOR
>> !        && ! TREE_SIDE_EFFECTS (DECL_INITIAL (var)))
>> 
> Put all this inside a static bool predicate, please.

What about moving them inside try_extract_*, separating the two cases?

Giovanni Bajo

Follow-Ups:
- Re: [PATCH] PR14841 and PR15838
  - From: Diego Novillo

References:
- [PATCH] PR14841 and PR15838
  - From: Steven Bosscher
- Re: [PATCH] PR14841 and PR15838
  - From: Diego Novillo

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]