This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] PR14841 and PR15838
- From: Diego Novillo <dnovillo at redhat dot com>
- To: Steven Bosscher <stevenb at suse dot de>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 31 Aug 2004 12:20:04 -0400
- Subject: Re: [PATCH] PR14841 and PR15838
- Organization: Red Hat Canada
- References: <200408311810.39786.stevenb@suse.de>
On Tue, 2004-08-31 at 12:10, Steven Bosscher wrote:
> ! else if (((TREE_CODE (rhs) == ARRAY_REF
> ! && TREE_CODE (var = TREE_OPERAND (rhs, 0)) == VAR_DECL
> ! && TREE_CODE (TREE_TYPE (var)) == ARRAY_TYPE)
> ! || (TREE_CODE (rhs) == COMPONENT_REF
> ! && TREE_CODE (var = TREE_OPERAND (rhs, 0)) == VAR_DECL
> ! && TREE_CODE (TREE_TYPE (var)) == RECORD_TYPE
> ! && TREE_CODE (TREE_OPERAND (rhs, 1)) == FIELD_DECL))
> ! && TREE_READONLY (var)
> ! && DECL_INITIAL (var)
> ! && TREE_CODE (DECL_INITIAL (var)) == CONSTRUCTOR
> ! && ! TREE_SIDE_EFFECTS (DECL_INITIAL (var)))
>
Put all this inside a static bool predicate, please.
OK with that change. Also, could you add both PRs to the testsuite? A
link_test() should be fine.
Thanks. Diego.