This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch for -mcaller-super-interworking & stack arguments

Richard Earnshaw <rearnsha@gcc.gnu.org> writes:
>> Btw, as a heads-up, I was just looking into how the new patch might be
>> written, and I noticed what seems to be a little thinko in the recent
>> changes to thumb_compute_save_reg_mask():
>> 
>>   if (flag_pic && !TARGET_SINGLE_PIC_BASE)
>>     mask |= PIC_OFFSET_TABLE_REGNUM;
>> 
>> Looks like it should be "mask |= 1 << ...".  I'm not really
>> set up to test that change myself though.
>
> You're right.  I think that even comes under the 'obvious' rule.

Yeah, I thought it might.  But like I say, I'm not really set
up to test thumb PIC (at least, not knowingly) so I thought I'd
better leave it to somehow who is.

Richard
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]