This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH: ObjC-specific changes to c-typeck.c
On Mon, 23 Aug 2004, Ziemowit Laski wrote:
> > However, there may be some good reason why it has to be done this way.
> > I would suggest you get Joseph Myers to look at this; he's more
> > familiar with c-typeck.c's intricacies than I am.
>
> Ok; I'll wait for word from him. Actually, he did approve this work
> previously (i.e., prior to the gengtype.c stuff going in), but I don't
> know if that approval is still operative. :-)
Actually, I declined to review it because I didn't consider ObjC-specific
code within my competence (and I consider what part of the compiler code
is associated with to be more a matter of function than of what source
file it is located in).
Past release criteria have said that the behaviro of the ObjC and Ada
front ends "will not be a primary consideration in determining whether or
not to ship a particular release candidate" so there may be a *little*
more latitude allowed to changes to those parts of the compiler than to
changes elsewhere, but as regressions still need to be avoided and the
code still needs to be maintainable by people who may not be familiar with
it, you should still seek to satisfy people with concerns that those
concerns are addressed, and add comments to the code explaining anything
about it and why it is needed that has proved unclear.
Is this change needed for some particular testcase already in the
testsuite (failing or XFAILed), already in the testsuite (which however
only fails when other changes are merged in, in which case you may need to
explain why the problem is here rather than with the other changes), or is
the testcase something not currently in the testsuite? Please name the
test or provide the testcase which fails before the patch and passes
afterwards, or the explanation for why there can't be a testcase. All
patch submissions should include testcases, references to existing ones
that are fixed or explanations of why one can't be included or isn't
needed, unless immediately obvious.
--
Joseph S. Myers http://www.srcf.ucam.org/~jsm28/gcc/
jsm@polyomino.org.uk (personal mail)
jsm28@gcc.gnu.org (Bugzilla assignments and CCs)