This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
RE: [Patch] boehm-gc/win32_threads.c: Get configuration defines
- From: "Boehm, Hans" <hans dot boehm at hp dot com>
- To: "'Bryce McKinlay'" <mckinlay at redhat dot com>,Danny Smith <danny_smith_0000 at yahoo dot co dot nz>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>,java-patches <java-patches at gcc dot gnu dot org>
- Date: Mon, 23 Aug 2004 13:38:29 -0700
- Subject: RE: [Patch] boehm-gc/win32_threads.c: Get configuration defines
By analogy how about the following, which I can't test?
Hans
Index: aix_irix_threads.c
===================================================================
RCS file: /cvs/gcc/gcc/boehm-gc/aix_irix_threads.c,v
retrieving revision 1.2
diff -u -r1.2 aix_irix_threads.c
--- aix_irix_threads.c 13 Aug 2004 23:05:29 -0000 1.2
+++ aix_irix_threads.c 23 Aug 2004 20:30:37 -0000
@@ -26,9 +26,10 @@
* as a base instead.
*/
+# include "private/gc_priv.h"
+
# if defined(GC_IRIX_THREADS) || defined(GC_AIX_THREADS)
-# include "private/gc_priv.h"
# include <pthread.h>
# include <assert.h>
# include <semaphore.h>
> -----Original Message-----
> From: java-patches-owner@gcc.gnu.org
> [mailto:java-patches-owner@gcc.gnu.org]On Behalf Of Bryce McKinlay
> Sent: Monday, August 23, 2004 8:07 AM
> To: Danny Smith
> Cc: GCC Patches; java-patches
> Subject: Re: [Patch] boehm-gc/win32_threads.c: Get
> configuration defines
>
>
> Thanks Danny. I'm going to check in this variant which should
> have the
> same effect but work in the upstream boehm-gc as well. Let me know if
> you still see any problems.
>
> Bryce
>
>
> 2004-08-23 Bryce McKinlay <mckinlay@redhat.com>
>
> * win32_threads.c: Move GC_WIN32_THREADS check after
> gc_priv.h include.
>
> --- win32_threads.c 13 Aug 2004 23:05:30 -0000 1.17
> +++ win32_threads.c 23 Aug 2004 15:03:50 -0000
> @@ -1,6 +1,7 @@
> +#include "private/gc_priv.h"
> +
> #if defined(GC_WIN32_THREADS)
>
> -#include "private/gc_priv.h"
> #include <windows.h>
>
> #ifdef CYGWIN32
>
>
> Danny Smith wrote:
>
> >Build of libgcj fails on mingw32 because of missing symbols from
> >boehm-gc/win32_threads.c. In fact, win32_threads.o is an empty file,
> >because the necessary configuration defines are no longer in the
> >makefile but in gc_config.h.
> >
> >This fixes:
> >
> >2004-08-23 Danny Smith <dannysith@users.sourceforge.net>
> >
> > * win32_threads.c: Include "gc_config.h"
> >
> >Index: win32_threads.c
> >===================================================================
> >RCS file: /cvs/gcc/gcc/boehm-gc/win32_threads.c,v
> >retrieving revision 1.17
> >diff -c -3 -p -r1.17 win32_threads.c
> >*** win32_threads.c 13 Aug 2004 23:05:30 -0000 1.17
> >--- win32_threads.c 22 Aug 2004 21:14:24 -0000
> >***************
> >*** 1,3 ****
> >--- 1,4 ----
> >+ #include "gc_config.h"
> > #if defined(GC_WIN32_THREADS)
> >
> > #include "private/gc_priv.h".
> >
> >Find local movie times and trailers on Yahoo! Movies.
> >http://au.movies.yahoo.com
> >
> >
>