This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH]: One declaration of abort


Nathan Sidwell <nathan@codesourcery.com> writes:

> Zack Weinberg wrote:
>
>> You can correct this by leaving the (elaborated) definition of
>> fancy_abort in gcov.c, or by adding rules to the Makefile to build two
>> copies of errors.o, one for build one for host (see the existing
>> treatment of rtl.c)  And if you like to rename all the object files
>> that are built only for the build machine, so that it's harder to make
>> this mistake in the future, that would be nice.
> ok, this separates build-errors.o from errors.o, ok if bootstrap and
> xcompile succeeds?

One other change is required:  errors.c now needs to have

#ifdef GENERATOR_FILE
#include "bconfig.h"
#else
#include "config.h"
#endif

instead of an unconditional include of bconfig.h.  Also,

[collect2.c]
> !   fatal ("internal gcc abort in %sm at %s:%d", func, file, line);
[gcc.c]
> !   fatal ("internal gcc abort in %sm at %s:%d", func, file, line);

looks like a typo for "%s,"?

OK with those fixed.

zw


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]