Re: Your hot/cold patch (config/i386/cygming.h)

[Caroline Tice <ctice at apple dot com>]

Yes I typed the wrong thing in this file.  I believe the patch below 
fixes the problem.  Okay to commit
(this seems fairly obvious to me,as  a typo)...I apologize for the 
inconvenience.

-- Caroline Tice
ctice@apple.com

Index: cygming.h
===================================================================
RCS file: /cvs/gcc/gcc/gcc/config/i386/cygming.h,v
retrieving revision 1.19
diff -c -3 -p -r1.19 cygming.h
*** cygming.h   18 Aug 2004 16:22:05 -0000      1.19
--- cygming.h   19 Aug 2004 19:39:11 -0000
*************** switch_to_section (enum in_section secti
*** 162,168 ****
    switch (section)                                            \
      {                                                         \
        case in_text: text_section (); break;                   \
!       case in_unlikely_text_section: unlikely_text_section (); break; 
\
        case in_data: data_section (); break;                   \
        case in_readonly_data: readonly_data_section (); break; \
        case in_named: named_section (decl, NULL, 0); break;    \
--- 162,168 ----
    switch (section)                                            \
      {                                                         \
        case in_text: text_section (); break;                   \
!       case in_unlikely_executed_text: unlikely_text_section (); 
break; \
        case in_data: data_section (); break;                   \
        case in_readonly_data: readonly_data_section (); break; \
        case in_named: named_section (decl, NULL, 0); break;    \


On Aug 19, 2004, at 12:25 PM, Gabriel Dos Reis wrote:

> Hi,
>
>    Your patch
>
>       http://gcc.gnu.org/ml/gcc-patches/2004-08/msg01140.html
>
> that touches config/i386/cygming.h is mistaken in that
> in_unlikely_text_section is not an in_section enumerator; rather it is
> the function designator you called right after.  That breaks build on
> cygwin for example.
>
> A simple testing of your patch on such environment would have revealed
> that thinko.
>
> -- Gaby