This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: First part of 64-bit Darwin support, revised


David Edelsohn wrote:

Stan,

I have reverted the MD portion of the patch and the rs6000.c
reference to gen_macho_*_di. The patch should have been tested on other
PowerPC configurations.


	There are a number of problems with the patch and it should not
have been committed.  Regardless whether the patterns are suppose to be
Darwin-specific, they have effects on other configurations, as you have
seen, so they should not be approved as "Darwin" only.

As Andreas has pointed out, the patterns that invoke output_call()
must have some other return value or abort() in the non-TARGET_MACHO
case.


match_parallel with a predicate of "any_operand" now is wrong.



OK.

And the match_parallel patterns appear to be generating RTL that
is unrecognized by lmw patterns in rs6000.md as seen by ppclinux32 and
aix32.


That's pretty weird, because they're all 64-bit and three are altivec-only.

Stan


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]