This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Your unroller patch
- From: Mark Mitchell <mark at codesourcery dot com>
- To: Zdenek Dvorak <rakdver at atrey dot karlin dot mff dot cuni dot cz>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Fri, 06 Aug 2004 01:18:22 -0700
- Subject: Your unroller patch
- Organization: CodeSourcery, LLC
I'd like to approve this patch:
http://gcc.gnu.org/ml/gcc-patches/2004-06/msg02425.html
but, this follow-on patch:
http://gcc.gnu.org/ml/gcc-patches/2004-07/msg01344.html
suggests that at least one code path was not fully tested, since the
incorrect use of SET_SRC and SET_DST probably would have resulted in
something weird happenning, if that code path had been taken. Would you
please rerun the testsuite with that change and your option enabled, and
repost, copying me?
Also, I'm concerned about adding to our already very long list of
optimization options. Is it reasonable to have this option always on
with -O2 or -O3? If not, when should it be used? At the least, the
documentation should say when this option is appropriate.
Thanks,
--
Mark Mitchell
CodeSourcery, LLC
(916) 791-8304
mark@codesourcery.com