This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] lno branch merge -- vectorizer patch #1
- From: Zdenek Dvorak <rakdver at atrey dot karlin dot mff dot cuni dot cz>
- To: Daniel Berlin <dberlin at dberlin dot org>
- Cc: Richard Henderson <rth at redhat dot com>, gcc-patches at gcc dot gnu dot org,Sebastian Pop <sebastian dot pop at cri dot ensmp dot fr>,Dorit Naishlos <DORIT at il dot ibm dot com>
- Date: Thu, 5 Aug 2004 10:21:20 +0200
- Subject: Re: [patch] lno branch merge -- vectorizer patch #1
- References: <F71388D0-E677-11D8-BB76-000A95DA505C@dberlin.org>
Hello,
> >On Wed, Aug 04, 2004 at 10:16:17PM +0200, Sebastian Pop wrote:
> >>Seems like a merge bug. We have kept the old name all along from
> >>tree-ssa days:
> >>
> >>2004-03-25 Diego Novillo <dnovillo@redhat.com>
> >>
> >> (pre_insert_on_edge): Rename from bsi_insert_on_edge_immediate.
> >
> >2004-07-09 Steven Bosscher <stevenb@suse.de>
> >
> > * tree-cfg.c (pre_insert_on_edge): Remove.
> >
> >
> >And in any case, I sincerely doubt you want the functionality that
> >this routine provided.
> >
> >
>
> Right, it was a bad hack for SSAPRE, which needed it because of some
> stupidity in the way the algorithm did insertions. You really want to
> just bsi_insert_on_edge and then bsi_commit_edge_insertions.
no, there are some places where we certainly do not want this -- why
should we call a function that scans over *all* edges in the flowgraph
when we want a simple insertion on an edge???
Zdenek