This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Request for testing on fold-const.c patch


    Also agreed.  But in your case there were different constructs at the 
    top-level:
      return (equal()
          && (cond1 ? bla : equal())
          && (cond2 ? ble : equal()))

    where cond[12] and bl[ae] were long on their own.  Splitting this
    would be justified IMHO.  Would all of the components be equal() calls
    I would leave them be merged.

Exactly.  That's why my last proposal was to make a macro to bury the
messiness so it would look like similar conditions.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]