This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH/RFC] Step 2 in getting GNU libobjc back to be able touse on Darwin, include files
- From: James E Wilson <wilson at specifixinc dot com>
- To: Andrew Pinski <pinskia at physics dot uc dot edu>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Mon, 26 Jul 2004 15:59:33 -0700
- Subject: Re: [PATCH/RFC] Step 2 in getting GNU libobjc back to be able touse on Darwin, include files
- References: <200406132248.i5DMm7H14209@tin.geop.uc.edu>
Andrew Pinski wrote:
This second step in getting GNU's libobjc working correctly
on Darwin.
Makes we wonder if I missed the first step, as I don't see it. Maybe it
was in the PR?
* c-incpath.h (target_c_incpath_s): Add extra_pre_includes.
Add two parameters to extra_includes.
(C_INCPATH_INIT): Add TARGET_EXTRA_PRE_INCLUDES.
...
OK. I spotted a few typos in comments, otherwise no serious concerns.
+ /* We do not do anything if we do not want the standard includes */
Missing the period and two spaces at the end of the sentence.
+ /* Register the GNU OBJC runtime inlcude path if this compiling GNU-runtime
+ and OBJ-C. */
inlcude -> include
"if this compiling" is awkward, maybe you meant "if this is compiling"?
Or maybe "if we are compiling"?
+ if (c_dialect_objc () && !flag_next_runtime)
It looks like you have a modified version of add_standard_paths from
c-incpath.c here. It might make more sense to put this in c-incpath.c
and just call it. That would avoid the need for including cpp header
files in darwin-c.c. But this is something we can worry about later I
think, especially since only darwin needs this code right now.
--
Jim Wilson, GNU Tools Support, http://www.SpecifixInc.com