This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Generated structure layout tests for gcc.dg/compat/struct-layout-1 (take 4)


On Fri, Jul 23, 2004 at 09:22:20AM -0400, Jakub Jelinek wrote:
> On Thu, Jul 22, 2004 at 06:29:52PM +0200, Michael Matz wrote:
> > > The generator uses pseudo-random generator, which I'm afraid will give
> > > different results between different hosts.
> > 
> > We could include a private version of a RNG, and fix the beginning seed.  
> > I don't think generating the files would be necessary, but it surely would
> > be nice, and satisfy my esthetic sense (of not including megabytes of
> > generated files)  ;-)
> 
> Assuming the license of glibc random.c/random_r.c is ok,
> here is 4th (and hopefully last) attempt for the struct-layout-1 testsuite,
> this time occupying less than 100KB in the testsuite.

I'll have to let someone who knows more about the licensing issues make
the call about adding the pseudo-random number generator, but the rest
looks good to me.  It might be nice to be able to specify a COUNT value,
but defining RUN_ALL_COMPAT_TESTS to get a large number (as implemented)
is probably sufficient.

Does this cover the same functionality as testsuite/consistency.vlad?
If so then perhaps we could remove that, but it's not my call.

Janis


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]