This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: PATCH: incorrect cost calculation in estimate_num_insns_1

From: Mike Stump <mrs at apple dot com>
To: Krister Walfridsson <cato at df dot lth dot se>
Cc: gcc-patches at gcc dot gnu dot org
Date: Fri, 16 Jul 2004 15:39:41 -0700
Subject: Re: PATCH: incorrect cost calculation in estimate_num_insns_1
References: <Pine.GSO.4.58.0407161214070.26413@igloo.df.lth.se>

On Jul 16, 2004, at 3:16 AM, Krister Walfridsson wrote:

I stumbled on a bug in estimate_num_insns_1 where it modifies a
pointer with
*count++;

where the code (and comment) indicates that

*count += 1;

was intended.

Hum, I can't help but think that someone in another 3 months will change the later form back into the first form.

Could we do:

(*count)++;

or even:

++ *count;

instead?

Follow-Ups:
- Re: PATCH: incorrect cost calculation in estimate_num_insns_1
  - From: Richard Henderson

References:
- PATCH: incorrect cost calculation in estimate_num_insns_1
  - From: Krister Walfridsson

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]