Re: [PATCH] Revert HJL's G++ generates local references to linkonce

[Mark Mitchell <mark at codesourcery dot com>]

Andrew Pinski wrote:

> > Andrew Pinski wrote:
> >
> >    
> >
> > > The problem with HJL's patch to fix G++ generates local references to linkonce is
> > > that it is wrong for targets which use the MAKE_DECL_ONE_ONLY target macro which I
> > > think only *-darwin does.
> > >
> > > I am only askinig reverting for the mainline as the 3.4 branch does not have the target
> > > macro.
> > >
> > > OK?
> > >
> > >      
> > OK.
> >
> > Since I approved the original patch, I can approve its reversion too. :-)
> >    
>
> I figured out a better way of fixing this regression besides reverting the patch.
> See <http://gcc.gnu.org/ml/gcc-patches/2004-07/msg00878.html>.
>
> Here is the updated patch which has been bootstrapped on powerpc-apple-darwin and fixes these
> two regressions and also should fix the regressions on the other targets too unlike my previous patch
> in the message above.
It seems to me like we ought to be able to determine  the linkage of a 
symbol before we start fiddling with it, now that we do compilation on a 
unit-at-a-time basis.  I can't find HJ's original test case anymore; 
would you point me at that?

And, in the mean time, would you like to revert HJ's patch until we 
figure out what we really want to do?

--
Mark Mitchell
CodeSourcery, LLC
(916) 791-8304
mark@codesourcery.com