This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] for PR16461

On Mon, 2004-07-12 at 07:07, Zdenek Dvorak wrote:
> Hello,
> 
> > > as Diego noted, tree-tailcall.c:independent_of_stmt_p must handle
> > > non-SSA name arguments of phi nodes.
> > > 
> > > Bootstrapped & regtested on ia64.
> > > 
> > > Zdenek
> > > 
> > > 	PR tree-optimization/16461
> > > 	* tree-tailcall.c (independent_of_stmt_p): Handle non-SSA name
> > > 	arguments of phi nodes.
> > I'd suggest using
> > 
> > if (TREE_CODE (expr) != SSA_NAME)
> >   break;
> > 
> > Instead since only an SSA_NAME is valid for EXPR in that loop.  Why
> > check is_gimple_min_invariant when it's clear that the only valid
> > node is an SSA_NAME?
> 
> sure.  Ok with the change?
Yes, OK with that change.
jeff
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]