This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: don't clear DECL_RTL of a DECL_REGISTER decl
On Jul 9, 2004, Zack Weinberg <zack@codesourcery.com> wrote:
> Given all this, I'd think Alexandre's original patch is correct. The
> last thing we want to do is introduce new explicit calls to
> assemble_variable(). To me it seems clear that
> check_global_declarations is the bad actor.
The second patch doesn't add new explicit calls to
assemble_variable(), it just protects additional cases that might set
DECL_RTL that check_global_declarations would have cleared. For
example, a global non-register variable with an asmspec.
FWIW, pme points out that my patch fixes gcc.dg/20020616-1.c, that had
recently regressed.
--
Alexandre Oliva http://www.ic.unicamp.br/~oliva/
Red Hat Compiler Engineer aoliva@{redhat.com, gcc.gnu.org}
Free Software Evangelist oliva@{lsd.ic.unicamp.br, gnu.org}