This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: re-establish NetWare as a supported (cross-only) target
- From: Richard Henderson <rth at redhat dot com>
- To: Jan Beulich <JBeulich at novell dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Wed, 7 Jul 2004 13:02:38 -0700
- Subject: Re: re-establish NetWare as a supported (cross-only) target
- References: <s0ebf17b.023@emea1-mh.id2.novell.com>
On Wed, Jul 07, 2004 at 01:50:19PM +0200, Jan Beulich wrote:
> +/* This function is required for all platforms that do not support the
> + .init/.fini mechanism of invoking constructors. Still, it's a dummy
> + for us since we use a different startup/shutdown approach. */
> +void __main(void) {}
You should probably be defining HAS_INIT_SECTION. It doesn't
mean *exactly* that .init/.fini sections are used; several other
platforms use this define with other startup mechanisms.
> + newsym = xmalloc (1 + strlen (asmname) + 1 + 10 + 1);
> + sprintf (newsym, "%c%s@%d", FASTCALL_PREFIX, asmname, total/BITS_PER_UNIT);
> + return IDENTIFIER_POINTER (get_identifier (newsym));
You're leaking memory.
> +# We don't need some of GCC's own include files.
> +USER_H = $(srcdir)/ginclude/stdarg.h \
> + $(srcdir)/ginclude/varargs.h \
> + $(srcdir)/unwind.h \
> + $(EXTRA_HEADERS) $(LANG_EXTRA_HEADERS)
Hmm? I think removing
$(srcdir)/ginclude/float.h \
$(srcdir)/ginclude/iso646.h \
$(srcdir)/ginclude/stdbool.h \
$(srcdir)/ginclude/stddef.h \
is sure to be a mistake. Indeed, I know for a fact that not
installing our stddef.h will break.
> +++ 2004-07-05.10.09/gcc/config/netware-libgcc.exp 2004-05-10 14:26:31.000000000 +0200
> @@ -0,0 +1,62 @@
> +# libgcc_s.nlm exports
> + (libgcc2),
> + __absvdi2,
> + __absvsi2,
> + __addvdi3,
> + __addvsi3,
> +# __ashldi3,
> +# __ashrdi3,
This is surely i386 specific.
> +++ 2004-07-05.10.09/gcc/config/t-nwld 2004-06-02 10:06:58.000000000 +0200
> @@ -0,0 +1,48 @@
> +CRTSTUFF_T_CFLAGS = -mpreferred-stack-boundary=2
> +CRT0STUFF_T_CFLAGS = -mpreferred-stack-boundary=2
This is definitely i386 specific.
Do *any* of the files you added to config/ really belong there?
Do you actually plan on supporting anything besides x86?
r~