Re: [PATCH]: Commence binfo extraction

[Nathan Sidwell <nathan at codesourcery dot com>]

Michael Elizabeth Chastain wrote:
> Hi Nathan,
>
> I think you missed one or two spots in dbxout.c, dbxout_type:
I will fix these forthwith.
>     case RECORD_TYPE:
>     case UNION_TYPE:
>     case QUAL_UNION_TYPE:
>       {
> 	int i, n_baseclasses = 0;
>
> 	if (TYPE_BINFO (type) != 0
> 	    && TREE_CODE (TYPE_BINFO (type)) == TREE_VEC
> 	    && TYPE_BINFO_BASETYPES (type) != 0)
> 	  n_baseclasses = TREE_VEC_LENGTH (TYPE_BINFO_BASETYPES (type));
>
> 'type' changed from TREE_VEC to TREE_BINFO and that's causing gcc to
> omit all the base class info from stabs.  I confirmed this with a
> debugger.
yes the above should be changed.

> There's one other spot in dbxout.c that uses TREE_VEC:
>
>   if (TREE_CODE (methods) != TREE_VEC)
>     fndecl = methods;
>   else if (TREE_VEC_ELT (methods, 0) != NULL_TREE)
>     fndecl = TREE_VEC_ELT (methods, 0);
>   else
>     fndecl = TREE_VEC_ELT (methods, 1);
>
> I'm really not sure what the right change there would be.
No change here.

nathan

--
Nathan Sidwell    ::   http://www.codesourcery.com   ::     CodeSourcery LLC
nathan@codesourcery.com    ::     http://www.planetfall.pwp.blueyonder.co.uk