This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] libgcj enable hash_syncronization & pthread_slow on darwin
- From: Bryce McKinlay <mckinlay at redhat dot com>
- To: Andreas Tobler <toa at pop dot agri dot ch>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Java Patches <java-patches at gcc dot gnu dot org>, Geoffrey Keating <geoffk at geoffk dot org>
- Date: Mon, 05 Jul 2004 17:15:03 -0400
- Subject: Re: [patch] libgcj enable hash_syncronization & pthread_slow on darwin
- References: <40E9C075.7060806@pop.agri.ch>
Andreas Tobler wrote:
the attached patch enables enable_hash_synchronization_default and
slow_pthread_self on darwin. The hash sync part is necessary to get
some swing stuff working. Without we hang forever.
About the benefit of slow_pthread_self I'm not quite sure. Maybe it
would help on a G5?
I do wonder if slow_pthread_self is neccessary on darwin.
Presumably/hopefully their ABI has a fast way to get the Thread ID? If
so then then the slow_pthread_self implementation may actually end up
being slower than a pthread_self() call, because it requires a read
barrier. We plan to remove slow_pthread_self eventually for Linux, once
most people are using nptl.
Otherwise, this patch looks good.
Regards
Bryce