This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: C++ patches ping ^3
- From: Nathan Sidwell <nathan at codesourcery dot com>
- To: Giovanni Bajo <giovannibajo at libero dot it>
- Cc: gcc-patches at gcc dot gnu dot org, Jason Merrill <jason at redhat dot com>, Mark Mitchell <mark at codesourcery dot com>, s_fsfeurope2 at nedprod dot com
- Date: Mon, 05 Jul 2004 09:37:05 +0100
- Subject: Re: C++ patches ping ^3
- Organization: Codesourcery LLC
- References: <045f01c461ce$ef0a3f80$ac4e2a97@bagio>
Giovanni Bajo wrote:
Hello,
the following C++ patches of mine are unreviewed:
[PR 14497] Remove leftover of the extension to specialize without template
headers
http://gcc.gnu.org/ml/gcc-patches/2004-06/msg01499.html
case tsk_excessive_parms:
! case tsk_insufficient_parms:
! if (tsk == tsk_excessive_parms)
^^^^^^^ this confused me.
! error ("too many template parameter lists in declaration of `%D'",
! decl);
! else if (template_header_count)
! error("too few template parameter lists in declaration of `%D'",
! decl);
! else
! error("explicit specialization of `%D' must be introduced by "
! "`template <>'", decl);
I'd find something like
case excessive:
error ("barf");
goto cleanup;
case insufficient:
...
case expl_spec:
cleanup:
to be more obvious
[PR 2518] Correct lookup of operator new
http://gcc.gnu.org/ml/gcc-patches/2004-06/msg02525.html
This is obviously correct.
nathan
--
Nathan Sidwell :: http://www.codesourcery.com :: CodeSourcery LLC
nathan@codesourcery.com :: http://www.planetfall.pwp.blueyonder.co.uk