This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH to use cpplib's source_location for location_t
Zack Weinberg wrote:
Considering that there is already DECL_BUILT_IN, I think
DECL_IS_BUILTIN is a bad name for that macro.
Yes, that is a little awkward.
The instances in the C
front end are all kludges intended to go away when someone fixes
Objective C not to generate fake non-builtin declarations with line
number 0 anymore; I don't know about the others.
I'm confused. DECL_IS_BUILTIN means that a decl is a __builtin
function decl. I don't see the connection with Objective C.
Maybe DECL_DECLARED_BY_COMPILER?
I already did check my patch in. Perhaps it would be better to
rename DECL_BUILT_IN to something more descriptive, such as
DECL_BUILTIN_FUNCTION or IS_BUILTIN_FUNCTION or BUILTIN_FUNCTION_P?
(The latter is probably not a good idea, as the existing BUILTIN_EXP10_P
works on function code, not FUNCTION_DECL nodes.)
--
--Per Bothner
per@bothner.com http://per.bothner.com/