This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [gfortran, committed] Fix typos in rand.c and normalize.c
- From: Steven Bosscher <stevenb at suse dot de>
- To: Steve Kargl <sgk at troutmask dot apl dot washington dot edu>,Tobias Schl?ter <tobias dot schlueter at physik dot uni-muenchen dot de>
- Cc: GCC Fortran mailing list <fortran at gcc dot gnu dot org>,patch <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 30 Jun 2004 10:22:44 +0200
- Subject: Re: [gfortran, committed] Fix typos in rand.c and normalize.c
- Organization: SUSE Labs
- References: <40E1F3A3.2000609@physik.uni-muenchen.de> <20040630033821.GA20535@troutmask.apl.washington.edu>
On Wednesday 30 June 2004 05:38, Steve Kargl wrote:
> On Wed, Jun 30, 2004 at 12:56:35AM +0200, Tobias Schl?ter wrote:
> > This patch fixes the rand intrinsic. We didn't actually call rand in it.
> > Fixing this involved Paul, Steven and myself, because a wrong comment in
> > normalize.c (also fixed) somewhat hampered our IRC conversation.
> >
> > Built and tested on i686-pc-linux, approved by Paul on IRC.
>
> Tested?
No, apparently. Tssk tssk :-P Making me panic because all regression
testers going ape and all fortran tests failing, and I thought it was
my patch ;-)
> > - return normalize_r4_i4 (i - 1, GFC_RAND_M1);
> > + return normalize_r4_i4 (irand (i) - 1, GFC_RAND_M1 - 1);
Commited this. Thanks
Gr.
Steven