This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] Add casts to some expressions produced by fortran frontend
- From: Steven Bosscher <stevenb at suse dot de>
- To: Zdenek Dvorak <rakdver at atrey dot karlin dot mff dot cuni dot cz>,gcc-patches at gcc dot gnu dot org
- Cc: fortran at gcc dot gnu dot org
- Date: Fri, 25 Jun 2004 00:45:42 +0200
- Subject: Re: [patch] Add casts to some expressions produced by fortran frontend
- Organization: SUSE Labs
- References: <20040624222148.GA25865@atrey.karlin.mff.cuni.cz>
On Friday 25 June 2004 00:21, Zdenek Dvorak wrote:
> Hello,
>
> fortran frontend sometimes tries to assign between expressions of
> different types. This causes ICE of one of candidate benchmarks for
> SPEC2004, and also failures of several tests in testsuite (forall_5.f90,
> intrinsic_associated.f90, ptr.f90, where_3.f90). This patch fixes
> (uhm... hacks over) these problems by adding casts to several places.
>
> Bootstrapped & regtested on x86_64.
Hi Zdenek,
Can you hold on to this for a little while? I plan to look into
it this Sunday, this appears to be a deeper problem somewhere.
In particular, in your first hunk I think we shouldn't cast to
the type of size but to size_t (size is assigned integer_one_node
earlier, so we always end up using the default type for that node
which is not right), and the second hunk definitely papers over
the real problem.
Please also post fortran patches to the fortran list next time ;-)
Gr.
Steven