This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: patch ping: simplify make_decl_rtl


----- Original Message -----
From: "Per Bothner"
| Danny Smith wrote:
|
| > Well, it does change handling of dllexport/dllimport override semantics
on
| > mingw and
| > cygwin.  In particular,  testsuite/g++.dg/ext/dllimport-2.C no longer
emits
| > the warnings
| > that were emitted by winnt.c::i386_pe_encode_section_info.  Those
warnings
| > do help to
| > catch dllimport/dllexport ambiguities in user code -- mainly where a
symbol
| > is declared as
| > dllimport, then used, then defined.
|
| There is actually a follow-up winnt.c patch:  The make_decl_rtl patch
| was just to simplify the problem, but it also needs a patch to winnt.c.
| This is attached; could you try if the regression remains?

Yes the regression remains because the patch you attached doesn't affect
dllimport/export.
Danny


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]