This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] testsuite fix for math tests on darwin
- From: Andrew Pinski <pinskia at physics dot uc dot edu>
- To: toa at pop dot agri dot ch (Andreas Tobler)
- Cc: gdr at integrable-solutions dot net (Gabriel Dos Reis), dalej at apple dot com (Dale Johannesen), gcc-patches at gcc dot gnu dot org (GCC Patches), libstdc++ at gcc dot gnu dot org (libstdc++)
- Date: Sun, 6 Jun 2004 14:27:00 -0400 (EDT)
- Subject: Re: [patch] testsuite fix for math tests on darwin
>
> Gabriel Dos Reis wrote:
> > Dale Johannesen <dalej@apple.com> writes:
> >
> > | On Jun 6, 2004, at 6:27 AM, Andreas Tobler wrote:
> > | > darwin has some C99 math functions in the libmx instead of libm, so
> > | > we should add the -lmx to the tests where we need these functions.
> > | > The attached patch fixes three failures of the libstdc++ suite.
> > | > Unfortunately I did not find the cabsl in libmx.
> > |
> > | There's been some discussion of this issue at Apple. I think we're
> > | leaning in the direction
> > | of having the driver include -lmx automagically. In fact I thought
> > | Andrew already had a
> > | patch in that did this for C++. Comments?
> >
> > I think that is the obvious solution, at least as far as V3 is
> > concerned. We don't require user to say -lm when they use C++.
> > I consider it to be a bug that the C driver requires that explicit
> > setting a bug -- but, hey, that is a different story :-)
>
> Ok, fine with me. But then we should find this patch and make it work.
>
> I just wanted to make them pass, to get a clear picture what is wrong
> and what is just not done correctly.
Yes I already did for the C++ driver but I did not know why the testcases
are still failing. I will look into them when I figure out what is wrong
with my hard drive in my laptop.
Thanks,
Andrew Pinski