This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] Make more includes explicit
- From: Roger Sayle <roger at eyesopen dot com>
- To: Zack Weinberg <zack at codesourcery dot com>
- Cc: Jerry Quinn <jlquinn at optonline dot net>, <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 4 Jun 2004 09:53:45 -0600 (MDT)
- Subject: Re: [patch] Make more includes explicit
On Fri, 4 Jun 2004, Zack Weinberg wrote:
> Roger Sayle <roger@eyesopen.com> writes:
> > You need to tweak the new comments above each #include. These need
> > to end with a period followed by two spaces. i.e. "/* For foo. */"
> > instead of "/* For foo */". Ok for mainline with those changes.
>
> NOT ok. See my other message.
Sorry, I'd missed that. I thought that he was just removing the
dependency upon reload.h from insn-conditions.o in the Makefile,
because that header wasn't included insn-conditions.c, i.e. the
#include wasn't generated by genconditions.c.
On more careful examination I see he's actually proposing a change
to gencoditions to remove the #include, which obviously is potentially
unsafe.
Apologies again,
Roger
--