This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] builtins.c: Fix PR tree-optimization/15738.

From: Kazu Hirata <kazu at cs dot umass dot edu>
To: law at redhat dot com
Cc: gcc-patches at gcc dot gnu dot org, roger at eyesopen dot com
Date: Wed, 02 Jun 2004 14:58:41 -0400 (EDT)
Subject: Re: [patch] builtins.c: Fix PR tree-optimization/15738.
References: <20040601.010705.32350989.kazu@cs.umass.edu><1086115678.2703.25.camel@speedy>

Hi Jeff,

> Shouldn't we try to put all the simplification/optimization stuff
> into fold_builtin_strchr, then have expand_builtin_strchr and
> expand_builtin_strrchr call the folder to simplify/optimize the call?
> That would avoid a lot of duplication.
> 
> [ And yes, that applies to most of the fold_builtin_XXX stuff I
>   added a while back.  Let's start with fixing the simple ones ;-) ]

Yes, the code duplication is definitely a concern.  I am thinking
about moving as much expand-time builtins optimizations as possible to
tree level, removing those expand-time optimizations, and then having
fold_builtin_BLAH call simplify_builtin_BLAH (or vive versa).

Kazu Hirata

References:
- [patch] builtins.c: Fix PR tree-optimization/15738.
  - From: Kazu Hirata
- Re: [patch] builtins.c: Fix PR tree-optimization/15738.
  - From: Jeffrey A Law

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]