This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH: Fix EH breakage on mainline
On Mon, May 31, 2004 at 10:14:26AM +0200, Jan Hubicka wrote:
> It seems to me that eh_return ought
> to barrier always and thus rest of targets should be probably turned
> into similar sollution to this one, right?
It should be a barrier on all targets, correct.
> * i386.md (UNSPECV_EH_RETURN): Kill.
> (eh_return): Use jump_insn.
> (eh_return_si, eh_return_di): Change pattern to jump instruction.
Assuming this passes bootstrap and test, yes.
> + rtx jmp;
...
> ! jmp = emit_jump_insn (gen_eh_return_si (sa));
> else
> ! jmp = emit_jump_insn (gen_eh_return_di (sa));
> emit_barrier ();
> DONE;
jmp instruction not used. Perhaps you meant to factor out
the call to emit_jump_insn?
r~