Re: [PATCH] new-bootstrap with preinstalling

[Alexandre Oliva <aoliva at redhat dot com>]

On May 11, 2004, Paolo Bonzini <paolo.bonzini@polimi.it> wrote:

> +	  --enable-languages="$(STAGE1_LANGUAGES)" \
> +	  --program-transform-name=s,y,y, && $(STAMP) ../configure-stage1-gcc

Couldn't you only override program-transform-name at stage-install
time?  Someone might be tempted to install stage1, and IMHO there's no
reason to prevent this from working.

> +	CC="$(STAGE_CC_WRAPPER) $$r/stage-prev/$(bindir)/gcc$(exeext) -B$$r/stage-prev/$(prefix)"; export CC; \

This is wrong.  $(prefix)/ (with the trailing slash) would be right,
but I don't see why it would be necessary.  The auto-detection of
relative pathname from bindir to libexecdir should work here.  Doesn't
it?

You may still need, however, -B flags for the already-installed
build_tooldir, in case you're bootstrapping gcc using a
previously-installed binutils in the same prefix.

Other than that, this is looking pretty cool.  I wish there was an
easy solution for the ln -s for dirs issue.

You may also have to consider sysroot issues.  When you add a new,
working install tree, the relocating code may get GCC to fail to find
the sys-root (or the deprecated --with-headers and --with-libraries
directories) in the install prefix, since it will think the whole
thing was relocated and may fail to look in the original install
prefix.  Would you please make sure this happens?  Just soft link the
sys-root dir to / in the install tree and build --with-sysroot.  If it
fails, we have a problem, and may have to add some support for this.

OTOH, the -B flags for $(build_tooldir)/bin may very well be enough to
avoid this problem.

-- 
Alexandre Oliva             http://www.ic.unicamp.br/~oliva/
Red Hat Compiler Engineer   aoliva@{redhat.com, gcc.gnu.org}
Free Software Evangelist  oliva@{lsd.ic.unicamp.br, gnu.org}