This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] UNSPEC_* source register handling in reg-stack.c
- From: Roger Sayle <roger at eyesopen dot com>
- To: Uros Bizjak <uros at kss-loka dot si>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Thu, 29 Apr 2004 06:16:10 -0600 (MDT)
- Subject: Re: [PATCH] UNSPEC_* source register handling in reg-stack.c
Hi Uros,
On Thu, 29 Apr 2004, Uros Bizjak wrote:
> 2004-04-29 Uros Bizjak <uros@kss-loka.si>
>
> * reg-stack.c (subst_stack_regs_pat): UNSPEC_SIN, UNSPEC_COS,
> UNSPEC_FRNDINT, UNSPEC_F2XM1: abort() if src1 dies.
> UNSPEC_SINCOS_COS, UNSPEC_TAN_ONE, UNSPEC_XTRACT_FRACT: Same.
> UNSPEC_SINCOS_SIN, UNSPEC_TAN_TAN, UNSPEC_XTRACT_EXP: Same.
The way to describe a change to cases of a switch statement in a
ChangeLog entry is to use angle brackets, i.e. <case FOO>. Hence
the above should probably read:
* reg-stack.c (subst_stack_regs_pat) <UNSPEC_SIN, UNSPEC_COS,
UNSPEC_FRNDINT, UNSPEC_F2XM1>: abort() if src1 dies.
<UNSPEC_SINCOS_COS, UNSPEC_TAN_ONE, UNSPEC_XTRACT_FRACT>: Same.
<UNSPEC_SINCOS_SIN, UNSPEC_TAN_TAN, UNSPEC_XTRACT_EXP>: Same.
The patch itself looks good. Ok for mainline, with the above tweak.
Thanks for splitting this up.
Roger
--