This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [ADA PATCH] Target macro definitions for s390*-linux*


Arnaud Charlet wrote:
> That's not really appropriate: each target should provide its own
> system dependent file, and no sharing of this file should be done (all
> the sharing done on this file in the past has caused confusion and bugs
> at one point or another).

Indeed, there needs to be at least one difference: Default_Bit_Order
(since s390 is big-endian) ...

> So instead please create new files, e.g. system-linux-s390.ads and
> system-linux-s390x.ads, thanks.

Done, see below.  Note that I am not sure I completlely understand
all the consequences of each of the system parameter settings, so 
if you notice something questionable, I'd appreciate feedback ... 

> > +   SYMLIB = $(ADDR2LINE_SYMLIB)
> > +   GMEM_LIB = gmemlib
> 
> These two lines should be removed, they are not needed/used on this
> configuration.

Done.

The following patch incorporates the above suggestions; I've retested
on s390-ibm-linux and s390x-ibm-linux with the same ACATS results.
OK?

Bye,
Ulrich


ChangeLog:

	* Makefile.in: Add target macro definitions for s390*-linux*.
	* system-linux-s390.ads: New file.
	* system-linux-s390x.ads: New file.

Index: gcc/ada/Makefile.in
===================================================================
RCS file: /cvs/gcc/gcc/gcc/ada/Makefile.in,v
retrieving revision 1.81
diff -c -p -r1.81 Makefile.in
*** gcc/ada/Makefile.in	28 Apr 2004 09:38:51 -0000	1.81
--- gcc/ada/Makefile.in	28 Apr 2004 14:52:19 -0000
*************** ifeq ($(strip $(filter-out %86 freebsd%,
*** 888,893 ****
--- 888,931 ----
    LIBRARY_VERSION := $(LIB_VERSION)
  endif
  
+ ifeq ($(strip $(filter-out s390% linux%,$(arch) $(osys))),)
+   ifeq ($(strip $(filter-out s390x,$(arch))),)
+     LIBGNAT_TARGET_PAIRS = \
+     a-intnam.ads<4lintnam.ads \
+     s-inmaop.adb<7sinmaop.adb \
+     s-intman.adb<7sintman.adb \
+     s-osinte.adb<5iosinte.adb \
+     s-osinte.ads<5iosinte.ads \
+     s-osprim.adb<7sosprim.adb \
+     s-taprop.adb<5itaprop.adb \
+     s-taspri.ads<5itaspri.ads \
+     s-tpopsp.adb<5atpopsp.adb \
+     s-parame.adb<5lparame.adb \
+     system.ads<system-linux-s390x.ads
+   else
+     LIBGNAT_TARGET_PAIRS = \
+     a-intnam.ads<4lintnam.ads \
+     s-inmaop.adb<7sinmaop.adb \
+     s-intman.adb<7sintman.adb \
+     s-osinte.adb<5iosinte.adb \
+     s-osinte.ads<5iosinte.ads \
+     s-osprim.adb<7sosprim.adb \
+     s-taprop.adb<5itaprop.adb \
+     s-taspri.ads<5itaspri.ads \
+     s-tpopsp.adb<5atpopsp.adb \
+     s-parame.adb<5lparame.adb \
+     system.ads<system-linux-s390.ads
+   endif
+ 
+   TOOLS_TARGET_PAIRS =  \
+     mlib-tgt.adb<5lml-tgt.adb
+ 
+   THREADSLIB = -lpthread
+   GNATLIB_SHARED = gnatlib-shared-dual
+   PREFIX_OBJS = $(PREFIX_REAL_OBJS)
+   LIBRARY_VERSION := $(LIB_VERSION)
+ endif
+ 
  ifeq ($(strip $(filter-out mips sgi irix%,$(targ))),)
    ifeq ($(strip $(filter-out mips sgi irix6%,$(targ))),)
      LIBGNAT_TARGET_PAIRS = \
*** /dev/null	Mon Mar 15 14:37:15 2004
--- gcc/ada/system-linux-s390.ads	Wed Apr 28 16:44:21 2004
***************
*** 0 ****
--- 1,150 ----
+ ------------------------------------------------------------------------------
+ --                                                                          --
+ --                        GNAT RUN-TIME COMPONENTS                          --
+ --                                                                          --
+ --                               S Y S T E M                                --
+ --                                                                          --
+ --                                 S p e c                                  --
+ --                          (GNU-Linux/s390 Version)                        --
+ --                                                                          --
+ --          Copyright (C) 1992-2003 Free Software Foundation, Inc.          --
+ --                                                                          --
+ -- This specification is derived from the Ada Reference Manual for use with --
+ -- GNAT. The copyright notice above, and the license provisions that follow --
+ -- apply solely to the  contents of the part following the private keyword. --
+ --                                                                          --
+ -- GNAT is free software;  you can  redistribute it  and/or modify it under --
+ -- terms of the  GNU General Public License as published  by the Free Soft- --
+ -- ware  Foundation;  either version 2,  or (at your option) any later ver- --
+ -- sion.  GNAT is distributed in the hope that it will be useful, but WITH- --
+ -- OUT ANY WARRANTY;  without even the  implied warranty of MERCHANTABILITY --
+ -- or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License --
+ -- for  more details.  You should have  received  a copy of the GNU General --
+ -- Public License  distributed with GNAT;  see file COPYING.  If not, write --
+ -- to  the Free Software Foundation,  59 Temple Place - Suite 330,  Boston, --
+ -- MA 02111-1307, USA.                                                      --
+ --                                                                          --
+ -- As a special exception,  if other files  instantiate  generics from this --
+ -- unit, or you link  this unit with other files  to produce an executable, --
+ -- this  unit  does not  by itself cause  the resulting  executable  to  be --
+ -- covered  by the  GNU  General  Public  License.  This exception does not --
+ -- however invalidate  any other reasons why  the executable file  might be --
+ -- covered by the  GNU Public License.                                      --
+ --                                                                          --
+ -- GNAT was originally developed  by the GNAT team at  New York University. --
+ -- Extensive contributions were provided by Ada Core Technologies Inc.      --
+ --                                                                          --
+ ------------------------------------------------------------------------------
+ 
+ package System is
+ pragma Pure (System);
+ --  Note that we take advantage of the implementation permission to
+ --  make this unit Pure instead of Preelaborable, see RM 13.7(36)
+ 
+    type Name is (SYSTEM_NAME_GNAT);
+    System_Name : constant Name := SYSTEM_NAME_GNAT;
+ 
+    --  System-Dependent Named Numbers
+ 
+    Min_Int               : constant := Long_Long_Integer'First;
+    Max_Int               : constant := Long_Long_Integer'Last;
+ 
+    Max_Binary_Modulus    : constant := 2 ** Long_Long_Integer'Size;
+    Max_Nonbinary_Modulus : constant := Integer'Last;
+ 
+    Max_Base_Digits       : constant := Long_Long_Float'Digits;
+    Max_Digits            : constant := Long_Long_Float'Digits;
+ 
+    Max_Mantissa          : constant := 63;
+    Fine_Delta            : constant := 2.0 ** (-Max_Mantissa);
+ 
+    Tick                  : constant := 0.000_001;
+ 
+    --  Storage-related Declarations
+ 
+    type Address is private;
+    Null_Address : constant Address;
+ 
+    Storage_Unit : constant := 8;
+    Word_Size    : constant := 32;
+    Memory_Size  : constant := 2 ** 32;
+ 
+    --  Address comparison
+ 
+    function "<"  (Left, Right : Address) return Boolean;
+    function "<=" (Left, Right : Address) return Boolean;
+    function ">"  (Left, Right : Address) return Boolean;
+    function ">=" (Left, Right : Address) return Boolean;
+    function "="  (Left, Right : Address) return Boolean;
+ 
+    pragma Import (Intrinsic, "<");
+    pragma Import (Intrinsic, "<=");
+    pragma Import (Intrinsic, ">");
+    pragma Import (Intrinsic, ">=");
+    pragma Import (Intrinsic, "=");
+ 
+    --  Other System-Dependent Declarations
+ 
+    type Bit_Order is (High_Order_First, Low_Order_First);
+    Default_Bit_Order : constant Bit_Order := High_Order_First;
+ 
+    --  Priority-related Declarations (RM D.1)
+ 
+    Max_Priority           : constant Positive := 30;
+    Max_Interrupt_Priority : constant Positive := 31;
+ 
+    subtype Any_Priority       is Integer      range  0 .. 31;
+    subtype Priority           is Any_Priority range  0 .. 30;
+    subtype Interrupt_Priority is Any_Priority range 31 .. 31;
+ 
+    Default_Priority : constant Priority := 15;
+ 
+ private
+ 
+    type Address is mod Memory_Size;
+    Null_Address : constant Address := 0;
+ 
+    --------------------------------------
+    -- System Implementation Parameters --
+    --------------------------------------
+ 
+    --  These parameters provide information about the target that is used
+    --  by the compiler. They are in the private part of System, where they
+    --  can be accessed using the special circuitry in the Targparm unit
+    --  whose source should be consulted for more detailed descriptions
+    --  of the individual switch values.
+ 
+    AAMP                      : constant Boolean := False;
+    Backend_Divide_Checks     : constant Boolean := False;
+    Backend_Overflow_Checks   : constant Boolean := False;
+    Command_Line_Args         : constant Boolean := True;
+    Configurable_Run_Time     : constant Boolean := False;
+    Denorm                    : constant Boolean := True;
+    Duration_32_Bits          : constant Boolean := False;
+    Exit_Status_Supported     : constant Boolean := True;
+    Fractional_Fixed_Ops      : constant Boolean := False;
+    Frontend_Layout           : constant Boolean := False;
+    Functions_Return_By_DSP   : constant Boolean := False;
+    Machine_Overflows         : constant Boolean := False;
+    Machine_Rounds            : constant Boolean := True;
+    OpenVMS                   : constant Boolean := False;
+    Signed_Zeros              : constant Boolean := True;
+    Stack_Check_Default       : constant Boolean := False;
+    Stack_Check_Probes        : constant Boolean := False;
+    Support_64_Bit_Divides    : constant Boolean := True;
+    Support_Aggregates        : constant Boolean := True;
+    Support_Composite_Assign  : constant Boolean := True;
+    Support_Composite_Compare : constant Boolean := True;
+    Support_Long_Shifts       : constant Boolean := True;
+    Suppress_Standard_Library : constant Boolean := False;
+    Use_Ada_Main_Program_Name : constant Boolean := False;
+    ZCX_By_Default            : constant Boolean := True;
+    GCC_ZCX_Support           : constant Boolean := True;
+    Front_End_ZCX_Support     : constant Boolean := False;
+ 
+    --  Obsolete entries, to be removed eventually (bootstrap issues!)
+ 
+    High_Integrity_Mode       : constant Boolean := False;
+    Long_Shifts_Inlined       : constant Boolean := True;
+ 
+ end System;
*** /dev/null	Mon Mar 15 14:37:15 2004
--- gcc/ada/system-linux-s390x.ads	Wed Apr 28 16:44:58 2004
***************
*** 0 ****
--- 1,150 ----
+ ------------------------------------------------------------------------------
+ --                                                                          --
+ --                        GNAT RUN-TIME COMPONENTS                          --
+ --                                                                          --
+ --                               S Y S T E M                                --
+ --                                                                          --
+ --                                 S p e c                                  --
+ --                          (GNU-Linux/s390x Version)                       --
+ --                                                                          --
+ --          Copyright (C) 1992-2003 Free Software Foundation, Inc.          --
+ --                                                                          --
+ -- This specification is derived from the Ada Reference Manual for use with --
+ -- GNAT. The copyright notice above, and the license provisions that follow --
+ -- apply solely to the  contents of the part following the private keyword. --
+ --                                                                          --
+ -- GNAT is free software;  you can  redistribute it  and/or modify it under --
+ -- terms of the  GNU General Public License as published  by the Free Soft- --
+ -- ware  Foundation;  either version 2,  or (at your option) any later ver- --
+ -- sion.  GNAT is distributed in the hope that it will be useful, but WITH- --
+ -- OUT ANY WARRANTY;  without even the  implied warranty of MERCHANTABILITY --
+ -- or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License --
+ -- for  more details.  You should have  received  a copy of the GNU General --
+ -- Public License  distributed with GNAT;  see file COPYING.  If not, write --
+ -- to  the Free Software Foundation,  59 Temple Place - Suite 330,  Boston, --
+ -- MA 02111-1307, USA.                                                      --
+ --                                                                          --
+ -- As a special exception,  if other files  instantiate  generics from this --
+ -- unit, or you link  this unit with other files  to produce an executable, --
+ -- this  unit  does not  by itself cause  the resulting  executable  to  be --
+ -- covered  by the  GNU  General  Public  License.  This exception does not --
+ -- however invalidate  any other reasons why  the executable file  might be --
+ -- covered by the  GNU Public License.                                      --
+ --                                                                          --
+ -- GNAT was originally developed  by the GNAT team at  New York University. --
+ -- Extensive contributions were provided by Ada Core Technologies Inc.      --
+ --                                                                          --
+ ------------------------------------------------------------------------------
+ 
+ package System is
+ pragma Pure (System);
+ --  Note that we take advantage of the implementation permission to
+ --  make this unit Pure instead of Preelaborable, see RM 13.7(36)
+ 
+    type Name is (SYSTEM_NAME_GNAT);
+    System_Name : constant Name := SYSTEM_NAME_GNAT;
+ 
+    --  System-Dependent Named Numbers
+ 
+    Min_Int               : constant := Long_Long_Integer'First;
+    Max_Int               : constant := Long_Long_Integer'Last;
+ 
+    Max_Binary_Modulus    : constant := 2 ** Long_Long_Integer'Size;
+    Max_Nonbinary_Modulus : constant := Integer'Last;
+ 
+    Max_Base_Digits       : constant := Long_Long_Float'Digits;
+    Max_Digits            : constant := Long_Long_Float'Digits;
+ 
+    Max_Mantissa          : constant := 63;
+    Fine_Delta            : constant := 2.0 ** (-Max_Mantissa);
+ 
+    Tick                  : constant := 0.000_001;
+ 
+    --  Storage-related Declarations
+ 
+    type Address is private;
+    Null_Address : constant Address;
+ 
+    Storage_Unit : constant := 8;
+    Word_Size    : constant := 64;
+    Memory_Size  : constant := 2 ** 64;
+ 
+    --  Address comparison
+ 
+    function "<"  (Left, Right : Address) return Boolean;
+    function "<=" (Left, Right : Address) return Boolean;
+    function ">"  (Left, Right : Address) return Boolean;
+    function ">=" (Left, Right : Address) return Boolean;
+    function "="  (Left, Right : Address) return Boolean;
+ 
+    pragma Import (Intrinsic, "<");
+    pragma Import (Intrinsic, "<=");
+    pragma Import (Intrinsic, ">");
+    pragma Import (Intrinsic, ">=");
+    pragma Import (Intrinsic, "=");
+ 
+    --  Other System-Dependent Declarations
+ 
+    type Bit_Order is (High_Order_First, Low_Order_First);
+    Default_Bit_Order : constant Bit_Order := High_Order_First;
+ 
+    --  Priority-related Declarations (RM D.1)
+ 
+    Max_Priority           : constant Positive := 30;
+    Max_Interrupt_Priority : constant Positive := 31;
+ 
+    subtype Any_Priority       is Integer      range  0 .. 31;
+    subtype Priority           is Any_Priority range  0 .. 30;
+    subtype Interrupt_Priority is Any_Priority range 31 .. 31;
+ 
+    Default_Priority : constant Priority := 15;
+ 
+ private
+ 
+    type Address is mod Memory_Size;
+    Null_Address : constant Address := 0;
+ 
+    --------------------------------------
+    -- System Implementation Parameters --
+    --------------------------------------
+ 
+    --  These parameters provide information about the target that is used
+    --  by the compiler. They are in the private part of System, where they
+    --  can be accessed using the special circuitry in the Targparm unit
+    --  whose source should be consulted for more detailed descriptions
+    --  of the individual switch values.
+ 
+    AAMP                      : constant Boolean := False;
+    Backend_Divide_Checks     : constant Boolean := False;
+    Backend_Overflow_Checks   : constant Boolean := False;
+    Command_Line_Args         : constant Boolean := True;
+    Configurable_Run_Time     : constant Boolean := False;
+    Denorm                    : constant Boolean := True;
+    Duration_32_Bits          : constant Boolean := False;
+    Exit_Status_Supported     : constant Boolean := True;
+    Fractional_Fixed_Ops      : constant Boolean := False;
+    Frontend_Layout           : constant Boolean := False;
+    Functions_Return_By_DSP   : constant Boolean := False;
+    Machine_Overflows         : constant Boolean := False;
+    Machine_Rounds            : constant Boolean := True;
+    OpenVMS                   : constant Boolean := False;
+    Signed_Zeros              : constant Boolean := True;
+    Stack_Check_Default       : constant Boolean := False;
+    Stack_Check_Probes        : constant Boolean := False;
+    Support_64_Bit_Divides    : constant Boolean := True;
+    Support_Aggregates        : constant Boolean := True;
+    Support_Composite_Assign  : constant Boolean := True;
+    Support_Composite_Compare : constant Boolean := True;
+    Support_Long_Shifts       : constant Boolean := True;
+    Suppress_Standard_Library : constant Boolean := False;
+    Use_Ada_Main_Program_Name : constant Boolean := False;
+    ZCX_By_Default            : constant Boolean := True;
+    GCC_ZCX_Support           : constant Boolean := True;
+    Front_End_ZCX_Support     : constant Boolean := False;
+ 
+    --  Obsolete entries, to be removed eventually (bootstrap issues!)
+ 
+    High_Integrity_Mode       : constant Boolean := False;
+    Long_Shifts_Inlined       : constant Boolean := True;
+ 
+ end System;

-- 
  Dr. Ulrich Weigand
  weigand@informatik.uni-erlangen.de


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]