This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: ping patches
- From: Per Bothner <per at bothner dot com>
- To: Andrew Pinski <pinskia at physics dot uc dot edu>
- Cc: java-patches at gcc dot gnu dot org, "gcc-patches at gcc dot gnu dot org Patches" <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 21 Apr 2004 12:01:30 -0700
- Subject: Re: ping patches
- References: <83078EF0-93B9-11D8-B035-000393A6D2F2@physics.uc.edu>
Andrew Pinski wrote:
Nobody has reviewed this patch yet:
<http://gcc.gnu.org/ml/java-patches/2004-q1/msg00912.html>
[PATCH] speedup the java front-end a little
The basic idea is fine.
To avoid an extra test, it looks like you allow ".class"
but not ".java". This probably doesn't matter, but the
code is a little hard to read.
Why not keep it simple:
return (len > 5 && strcmp (base + len - 5, ".java"))
|| (len > 6 && strcmp (base + len - 6, ".class"));
--
--Per Bothner
per@bothner.com http://per.bothner.com/