This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [debug/13267] proposed patch to dwarf2out.c
- From: Jim Wilson <wilson at specifixinc dot com>
- To: DJ Delorie <dj at redhat dot com>
- Cc: fnf at ninemoons dot com, gcc-patches at gcc dot gnu dot org
- Date: 20 Apr 2004 17:06:45 -0700
- Subject: Re: [debug/13267] proposed patch to dwarf2out.c
- References: <200403022204.i22M4JLN008210@greed.delorie.com><40482A76.9090900@specifixinc.com> <200403052126.i25LQD9w007426@greed.delorie.com><1078528672.1051.46.camel@leaf.tuliptree.org> <200403052352.i25NqqRg006563@greed.delorie.com><1078535015.1051.118.camel@leaf.tuliptree.org> <200403060132.i261W0Jg021651@greed.delorie.com><1078912953.1054.214.camel@leaf.tuliptree.org> <200404201732.i3KHWlvu004660@greed.delorie.com>
On Tue, 2004-04-20 at 10:32, DJ Delorie wrote:
> * dwarf2out.c (rtl_for_decl_location): Adjust rtl for byte
> variables stored in word registers, then in memory.
The last sentence of the comment is wrong. The comment says we can't
fix this in rtl_for_decl_location, but we are fixing it there. This
must be left over from an earlier version of the patch.
In the interests of speed, it is probably a good idea to add a mode
check, i.e.
GET_MODE (rtl) != TYPE_MODE (TREE_TYPE (decl))
there is no point in doing the calculations if the modes are the same,
and this will be true almost all of the time.
Otherwise this is OK.
--
Jim Wilson, GNU Tools Support, http://www.SpecifixInc.com