This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Bug bootstrap/14905] 'make install' fails on grepjar.1, not included in tarball [v2]
- From: Alexandre Oliva <aoliva at redhat dot com>
- To: Kelley Cook <kcook at gcc dot gnu dot org>
- Cc: gcc-bugzilla at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org, Mark Mitchell <mark at codesourcery dot com>
- Date: 12 Apr 2004 14:20:14 -0300
- Subject: Re: [Bug bootstrap/14905] 'make install' fails on grepjar.1, not included in tarball [v2]
- Organization: Red Hat Global Engineering Services Compiler Team
- References: <407AB1E3.5090909@ford.com>
On Apr 12, 2004, Kelley Cook <kcook34@ford.com> wrote:
> +stamp-geninsrc: jar.1 grepjar.1 fastjar.info
> + -cp -p $(top_builddir)/jar.1 $(srcdir)/jar.1
> + -cp -p $(top_builddir)/grepjar.1 $(srcdir)/grepjar.1
> + -cp -p $(top_builddir)/fastjar.info $(srcdir)/fastjar.info
Hmm... This construct is dangerous.
Consider broken VPATH makes such as Solaris' (yuck). If the jar.1 dep
resolves to $(srcdir)/jar.1 by VPATH search (which would happen if you
take a release tarball containing the generated doc files), every
occurrence of the jar.1 string in make commands will be replaced with
$(srcdir)/jar.1. In this case, your construct wouldn't work.
'fraid I don't have any good suggestions on how to work around this
problem.
Hmm... Maybe we don't have to. We do require GNU make now, don't we?
--
Alexandre Oliva http://www.ic.unicamp.br/~oliva/
Red Hat Compiler Engineer aoliva@{redhat.com, gcc.gnu.org}
Free Software Evangelist oliva@{lsd.ic.unicamp.br, gnu.org}