Re: PATCH: New optimization, partitioning hot/cold basic blocks

[Roger Sayle <roger at eyesopen dot com>]

On Sat, 10 Apr 2004, Andrew Pinski wrote:
>
> 	* varasm.c (text_section): Use TEXT_SECTION_ASM_OP and
> 	ASM_OUTPUT_ALIGN instead of SECTION_FORMAT_STRING
> 	and NORMAL_TEXT_SECTION_NAME.
> 	(unlikely_text_section): Check targetm.have_named_sections
> 	instead of TARGET_ASM_NAMED_SECTION and use TEXT_SECTION_ASM_OP
> 	instead of SECTION_FORMAT_STRING.
> 	* config/mips/iris5.h (current_section_name): Add
>       in_unlikely_executed_text case and move the abort into the switch.
> 	* config/rs6000/sysv4.h (HOT_TEXT_SECTION_NAME): Remove.
> 	(NORMAL_TEXT_SECTION_NAME): Remove.
> 	(UNLIKELY_EXECUTED_TEXT_SECTION_NAME): Remove.
> 	(SECTION_FORMAT_STRING): Remove.
> 	* defaults.h (SECTION_FORMAT_STRING): Remove.
> 	* tm.texi (NORMAL_TEXT_SECTION_NAME): Remove.
> 	(SECTION_FORMAT_STRING): Remove.

Hi Andrew,

In the interests of fixing bootstrap on AIX, HPUX, Tru64, IRIX,
Solaris, Cygwin and elsewhere, I think this patch is OK for mainline,
provided testing shows it fixes problems, and preferrable to eventually
reverting Caroline's patch under the 48 hour rule, as I suspect she
won't have a chance to investigate the issue until after that deadline.

Once the CVS tree is stable again, we can investigate Mike Stump's
preferences for section-state tracking.


Once this fix is in, I believe that Andreas Tobler's changes to
sparc/sysv4.h will no longer required for bootstrapping SPARC.  If
someone could confirm that's the case with a bootstrap, I preapprove
the patch to revert that workaround.

Thanks to everyone working on resolving this quickly.

Roger
--