Re: Second patch ping

[Zack Weinberg <zack at codesourcery dot com>]

Ian Lance Taylor <ian@wasabisystems.com> writes:

> This is my second ping for these patches.
>
> In my opinion, these patches are pretty clearly correct.  They are not
> rocket science, and do not involve complex interactions with the rest
> of the compiler.  Since gcc is in stage 1, there is time to fix any
> build problems which may arise.  It would be nice if somebody would
> take a look at them.  Thanks.
>
> http://gcc.gnu.org/ml/gcc-patches/2004-03/msg01585.html
>   Fix PR target/14548, clean up USE_COLLECT2 and make it
>   host-dependent rather than target-dependent

You must get a build system maintainer (Alexandre Oliva for instance)
to review this one.

> http://gcc.gnu.org/ml/gcc-patches/2004-03/msg01445.html
>   Change collect2 to not call vfork, as a step toward making it
>   buildable on hosts which can not fork

I do not like the approach you have taken in libiberty.  Instead of
coming up with a general and *simple* interface that can handle both
what pexecute does now and what collect2 needs, you have invented a
new interface which is just as inflexible as pexecute, only it does
something slightly different, and furthermore it duplicates a lot of
code from pexecute.

zw