Re: [patch] function inlining when optimize for size (PR11830)

[Geoff Keating <geoffk at geoffk dot org>]

Gábor Lóki <loki@inf.u-szeged.hu> writes:

> Hi,
> 
> I have examined if it is possible to use the function inlining when
> optimizing for size. I've found we can use it without any risk because
> when the max-inline-insns-* parameters were set with a small value
> the function inlining doesn't inline large functions.
> 
> It is also fix the PR11830 (http://gcc.gnu.org/PR11830).
> 
> I measuerd the size effect on CSiBE and this patch made about 1% code
> size save (arm:1.212%, i386:1.024%, i686:1.029%, m68k:0.795%,
> mips:1.096%, ppc:1.106%).
> 
> Bootstrapped and regtested on i686-pc-linux-gnu and regtested also on
> {arm,mips,ppc}-elf with no new failures.
> 
> Is it OK for mainline?

This is OK, except:

> +      /* Do the functions inlining with very small max-inline-insns-*. 

This would be better written "Do function inlining".  With that
change, please check it in.

> +         handle_options could overwrite if it's necessary.  */
> +      set_param_value ("max-inline-insns-single", 5);
> +      set_param_value ("max-inline-insns-auto", 5);
> +      set_param_value ("max-inline-insns-rtl", 10);
> +      flag_inline_functions = 1;
> +    }
>  
>    /* Initialize whether `char' is signed.  */
>    flag_signed_char = DEFAULT_SIGNED_CHAR;
> 
> 
> 

-- 
- Geoffrey Keating <geoffk@geoffk.org>