This is the mail archive of the mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [C++ patch] [PR 9283] Implement per-class visibility attribute[resend]

On Wed, 24 Mar 2004 20:31:36 -0800, Brian Ryner <> wrote:

> I did the overrides that way because handle_visibility_attribute
> (c-common.c) sets no_add_attrs=true, so the attribute is not present on the
> decl after the visibility bits are set in the tree_decl.  I wasn't sure
> what the implications would be of changing that.

Please try it and see.

> As for caching the class visibility on current_class_stack, I wasn't sure
> how to attach the attribute to the decl without passing it through to
> decl_attributes(), which would then wind up in
> handle_visibility_attribute(), which would have to somehow know that
> visibility is ok on a type decl, for C++ (but probably not C, since it
> doesn't have any meaning).  This approach does have the advantage of not
> taking extra per-class-decl memory when visibility is specified, once the
> class is done being parsed.

Yep.  You could even add a macro


It seems like decl_attributes can't currently deal with an attribute which
is valid on both decls and types, so it'll need some adjustment.

handle_visibility_attribute would just need to pull out the decl from


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]