This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Bad choices by expand_mult_highpart


Richard Sandiford wrote:

>     extra_cost = shift_cost[GET_MODE_BITSIZE (mode) - 1];

Here you may be accessing outside the array bounds of shift_cost;
that's why I had the test earlier ...

Apart from this the patch looks OK to me.  Do you have any results
on whether the code gets in fact better?  You avoid the adjustment,
but on the other hand you call synth_mult with an integer with a
lot more 1 bits set; I'm not sure I can easily see which one is
better.

Bye,
Ulrich

-- 
  Dr. Ulrich Weigand
  weigand@informatik.uni-erlangen.de


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]