Re: PATCH for java.nio FileChannel and MappedByteBuffer

[Mike Stump <mrs at apple dot com>]

On Sunday, March 7, 2004, at 07:47 AM, andreas tobler wrote:
> Per Bothner wrote:
> > Index: gnu/java/nio/channels/natFileChannelImpl.cc
> > ===================================================================
> > RCS file: gnu/java/nio/channels/natFileChannelImpl.cc
> > diff -N gnu/java/nio/channels/natFileChannelImpl.cc
> > --- /dev/null	1 Jan 1970 00:00:00 -0000
> > +++ gnu/java/nio/channels/natFileChannelImpl.cc	20 Feb 2004 01:27:57  
> > -0000
>
> > +void
> > +MappedByteBufferImpl::unmapImpl ()
> > +{
> > +#if defined(__JV_POSIX_H__) && defined(HAVE_MMAP)
> > +  munmap((void*) implPtr, implLen);
>
> munmap and the msync below cause here some headache.

I am seeing a bootstrap error on darwin:

 /Volumes/mrs3/net/gcc-darwin/gcc/xgcc -shared-libgcc  
-B/Volumes/mrs3/net/gcc-darwin/gcc/ -nostdinc++  
-L/Volumes/mrs3/net/gcc-darwin/powerpc-apple-darwin7.2.0/libstdc++-v3/ 
src  
-L/Volumes/mrs3/net/gcc-darwin/powerpc-apple-darwin7.2.0/libstdc++-v3/ 
src/.libs  
-B/Volumes/mrs3/Packages/gcc-20040315/powerpc-apple-darwin7.2.0/bin/  
-B/Volumes/mrs3/Packages/gcc-20040315/powerpc-apple-darwin7.2.0/lib/  
-isystem  
/Volumes/mrs3/Packages/gcc-20040315/powerpc-apple-darwin7.2.0/include  
-isystem  
/Volumes/mrs3/Packages/gcc-20040315/powerpc-apple-darwin7.2.0/sys- 
include -dynamiclib -flat_namespace -undefined suppress -o  
.libs/libgcj.6.0.0.dylib .libs/libgcj.6.0.0.dylib-master.o    
-L/Volumes/mrs3/net/gcc-darwin/powerpc-apple-darwin7.2.0/libstdc++-v3/ 
src  
-L/Volumes/mrs3/net/gcc-darwin/powerpc-apple-darwin7.2.0/libstdc++-v3/ 
src/.libs  
-L/Volumes/mrs3/net/gcc-darwin/powerpc-apple-darwin7.2.0/libjava  
../boehm-gc/.libs/libgcjgc_convenience.a  
../libffi/.libs/libffi_convenience.a  
../zlib/.libs/libzgcj_convenience.a -lpthread  
./libltdl/.libs/libltdlc.a -ldl     -lc  -install_name   
/Volumes/mrs3/Packages/gcc-20040315/lib/libgcj.6.dylib  
-compatibility_version 7 -current_version 7.0
ld: warning multiple definitions of symbol _sqrt
.libs/libgcj.6.0.0.dylib-master.o definition of _sqrt in section  
(__TEXT,__text)
/usr/lib/libpthread.dylib(sqrt970.o) definition of _sqrt
ld: .libs/libgcj.6.0.0.dylib-master.o has external relocation entries  
in non-writable section (__TEXT,__text) for symbols:
_libiconv
_msync
_munmap
/usr/bin/libtool: internal link edit command failed
make[2]: *** [libgcj.la] Error 1
make[2]: Leaving directory  
`/Volumes/mrs3/net/gcc-darwin/powerpc-apple-darwin7.2.0/libjava'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory  
`/Volumes/mrs3/net/gcc-darwin/powerpc-apple-darwin7.2.0/libjava'
make: *** [all-target-libjava] Error 2

I think Geoff's tester is offline, as otherwise I think it would have  
complained about it.  Could the person that broke it fix it, thanks.  I  
don't know exactly who that is.