Re: [patch] function inlining when optimize for size (PR11830)

[Andreas Jaeger <aj at suse dot de>]

Gábor Lóki <loki@inf.u-szeged.hu> writes:

> Hi,
>
> I have examined if it is possible to use the function inlining when
> optimizing for size. I've found we can use it without any risk because
> when the max-inline-insns-* parameters were set with a small value
> the function inlining doesn't inline large functions.
>
> It is also fix the PR11830 (http://gcc.gnu.org/PR11830).
>
> I measuerd the size effect on CSiBE and this patch made about 1% code
> size save (arm:1.212%, i386:1.024%, i686:1.029%, m68k:0.795%,
> mips:1.096%, ppc:1.106%).
>
> Bootstrapped and regtested on i686-pc-linux-gnu and regtested also on
> {arm,mips,ppc}-elf with no new failures.
>
> Is it OK for mainline?
>
>
> Regards,
>            Gábor Lóki
>
>
>
> 2004-03-17  Gábor Lóki <loki@inf.u-szeged.hu>
>
> 	* opts.c (decode_options): Do function inlining with very small
> 	max-inline-insns-* parameters when optimizing for size

What happens if the user passes these parameter on the command line?
In that case the user supplied option has to work IMO.  Have you
tested this?

Andreas
-- 
 Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj
  SuSE Linux AG, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126

Attachment: pgp00000.pgp
Description: PGP signature